Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the polaris config relation non-daemon thread should stop when application fails to start. #1102

Merged

Conversation

shuiqingliu
Copy link
Contributor

PR Type

Bugfix

Describe what this PR does for and how you did.

the polaris config relation non-daemon thread should stop when application fails to start.

Adding the issue link (#xxx) if possible.

#1032

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2020.0.
  • Will pull request to branch of 2022.0.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1102 (aa1f4a7) into 2022.0 (50fcb11) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             2022.0    #1102      +/-   ##
============================================
+ Coverage     81.26%   81.27%   +0.01%     
- Complexity     1671     1675       +4     
============================================
  Files           252      253       +1     
  Lines          5684     5694      +10     
  Branches        661      662       +1     
============================================
+ Hits           4619     4628       +9     
+ Misses          685      684       -1     
- Partials        380      382       +2     
Files Changed Coverage Δ
...polaris/config/PolarisConfigAutoConfiguration.java 100.00% <ø> (ø)
...stener/PolarisContextApplicationEventListener.java 44.44% <44.44%> (ø)
...ontext/config/PolarisContextAutoConfiguration.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

SkyeBeFreeman and others added 3 commits September 12, 2023 17:47
…qingliu/spring-cloud-tencent into fix-long-pulling-thread-stop-2022.0
if we register a destroy hook for RemoteConfigFileRepo on the class instance , the static thread pool may be terminated by the bootstrap context closing ,Therefore,it's better to register the destroy hook when the  application is prepared, or when the application fails to start, in order to properly destroy resources
@SkyeBeFreeman SkyeBeFreeman merged commit 0e44d6e into Tencent:2022.0 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polaris' connect did not automatically stop when spring boot application has stopped
2 participants