Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nacos namespace mapping #1122

Merged
merged 9 commits into from
Oct 26, 2023

Conversation

wenxuan70
Copy link
Contributor

PR Type

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

Note

支持映射nacos命名空间,参考以下:
#737

需要polaris-java支持,相关PR:
polarismesh/polaris-java#425

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2020.0.
  • Will pull request to branch of 2022.0.

@wenxuan70 wenxuan70 force-pushed the feature/nacos-namespace branch from aa89cec to e3b7385 Compare September 17, 2023 08:47
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1122 (a553cc0) into 2021.0 (e732dee) will decrease coverage by 0.05%.
Report is 1 commits behind head on 2021.0.
The diff coverage is 66.66%.

❗ Current head a553cc0 differs from pull request most recent head ce989b5. Consider uploading reports for the commit ce989b5 to get more accurate results

@@             Coverage Diff              @@
##             2021.0    #1122      +/-   ##
============================================
- Coverage     75.60%   75.55%   -0.05%     
+ Complexity     1641     1639       -2     
============================================
  Files           259      258       -1     
  Lines          6041     6010      -31     
  Branches        746      745       -1     
============================================
- Hits           4567     4541      -26     
- Misses         1071     1073       +2     
+ Partials        403      396       -7     
Files Coverage Δ
...tencent/cloud/common/metadata/MetadataContext.java 86.95% <100.00%> (+0.19%) ⬆️
...loud/polaris/extend/nacos/NacosConfigModifier.java 62.22% <50.00%> (-0.57%) ⬇️
...d/polaris/extend/nacos/NacosContextProperties.java 52.77% <50.00%> (-0.35%) ⬇️
...a/com/tencent/cloud/common/util/DiscoveryUtil.java 77.77% <72.72%> (-2.23%) ⬇️

... and 13 files with indirect coverage changes

@SkyeBeFreeman SkyeBeFreeman merged commit 9888dd7 into Tencent:2021.0 Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

多注册中心支持将nacos中的namespace映射到指定的polaris的环境类型
2 participants