Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the logging problem open at #1189. #1196

Merged

Conversation

ShangfengDing
Copy link
Contributor

利用logging.level.xx.xx=trace配置日志级别时,北极星日志配置失效。polaris-java的日志都打印在控制台。
通过在 PolarisConfigLoggerApplicationListener 加上 PolarisLogging.getInstance().loadConfiguration(); 后,可以避免 Polaris 的配置失效,这时候用户配置的内容不会影响北极星日志

fixes #1189

Note

Checklist

  • [ ✅] Add information of this PR to CHANGELOG.md in root of project.

Checklist (Optional)

  • [✅ ] Will pull request to branch of 2020.0.
  • [✅ ] Will pull request to branch of 2022.0.
  • [ ✅] Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 1.13.0 milestone Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1196 (14c3c78) into 2022.0 (e34fe66) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             2022.0    #1196      +/-   ##
============================================
- Coverage     77.03%   77.00%   -0.03%     
+ Complexity     1642     1640       -2     
============================================
  Files           260      260              
  Lines          5940     5941       +1     
  Branches        735      735              
============================================
- Hits           4576     4575       -1     
  Misses          956      956              
- Partials        408      410       +2     
Files Coverage Δ
...logger/PolarisConfigLoggerApplicationListener.java 84.61% <100.00%> (+1.28%) ⬆️

... and 1 file with indirect coverage changes

@SkyeBeFreeman SkyeBeFreeman merged commit 7b31121 into Tencent:2022.0 Nov 1, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

利用logging.level.xx.xx=trace配置日志级别时,北极星日志配置失效
2 participants