Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix reporter wrong initialization when using config data. #1221

Merged

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Bugfix.

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

fixes #1219

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2020.0.
  • Will pull request to branch of 2022.0.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 1.13.0 milestone Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0fa2d8b) 75.56% compared to head (b2ed5c1) 75.56%.

Files Patch % Lines
.../configdata/PolarisConfigDataLocationResolver.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             2021.0    #1221      +/-   ##
============================================
- Coverage     75.56%   75.56%   -0.01%     
  Complexity     1646     1646              
============================================
  Files           259      259              
  Lines          6066     6068       +2     
  Branches        754      755       +1     
============================================
+ Hits           4584     4585       +1     
  Misses         1075     1075              
- Partials        407      408       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman merged commit 18e9d5d into Tencent:2021.0 Jan 15, 2024
8 of 9 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 2021/fix-config-data-reporter branch January 17, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spring.cloud.polaris.stat.enabled=false时,Prometheus的httpserver可能存在临时开启的问题
1 participant