Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): Menu side logo style lack docs Menu side logo style #1602

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

HaixingOoO
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Closed 3407

💡 需求背景和解决方案

Menu side logo style lack docs Menu side logo style

📝 更新日志

  • fix(Menu): 修复菜单侧Logo切换的样式缺失,和官网展示一致。

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

tdesign-vue preview 地址:(如果你有 DOM 变动请自行在对应技术栈仓库中发起 PR)
完成

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaixingOoO HaixingOoO requested a review from uyarn September 25, 2023 08:40
HaixingOoO

This comment was marked as off-topic.

@HaixingOoO
Copy link
Collaborator Author

如果补充了这个 docs的相关代码就移除吧 https://github.com/Tencent/tdesign-common/blob/develop/style/web/components/menu/_docs.less#L81

done.

@uyarn uyarn merged commit 9def3fe into Tencent:develop Sep 26, 2023
6 checks passed
@HaixingOoO HaixingOoO deleted the fix/Menu branch September 26, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Menu] 实际导航菜单的LOGO与官网不符
3 participants