Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tree): setData improvement, and fix data update problems in Vue3 #1603

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

TabSpace
Copy link
Contributor

🤔 这个 PR 的性质是?

  • ☑️ 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • ☑️ 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

统一 vue2, vue3 代码时,发现节点新增属性难以在 vue3 treeNode 上更新,因此修改方法来解决 vue3 的节点刷新问题。

📝 更新日志

  • fix(tree): treeNodeModel 的 setData 方法应当触发 update 事件,用于 vue-next 项目触发数据更新。

  • refactor(tree): tree 组件 updatedMap 改为用 privateKey 作为唯一 id, 业务中不使用这个 map 对象

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • ☑️ 文档已补充或无须补充
  • ☑️ 代码演示已提供或无须提供
  • ☑️ TypeScript 定义已补充或无须补充
  • ☑️ Changelog 已提供或无须提供

@TabSpace TabSpace changed the title refactor: 💡 tree 组件,完善数据更新 setData api,解决 vue3 的数据更新问题 WIP refactor: 💡 tree 组件,完善数据更新 setData api,解决 vue3 的数据更新问题 Sep 25, 2023
@TabSpace TabSpace changed the title WIP refactor: 💡 tree 组件,完善数据更新 setData api,解决 vue3 的数据更新问题 refactor: 💡 tree 组件,完善数据更新 setData api,解决 vue3 的数据更新问题 Sep 26, 2023
@chaishi chaishi changed the title refactor: 💡 tree 组件,完善数据更新 setData api,解决 vue3 的数据更新问题 refactor(tree): setData improvement, and fix data update problems in Vue3 Oct 10, 2023
@chaishi chaishi merged commit 4e743c3 into Tencent:develop Oct 10, 2023
6 checks passed
@TabSpace TabSpace deleted the refactor/tree/adapt branch November 28, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants