Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Upload): fix upload image error style #1795

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented May 14, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Upload): 修复图片异常的样式问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link

tdesign-vue preview 地址:(如果你有 DOM 变动请自行在对应技术栈仓库中发起 PR)
完成

@Except10n
Copy link

.@{prefix}-is--progress 也存在这个样式问题

@HaixingOoO
Copy link
Collaborator

@uyarn 大佬有空时看看progress的样式问题

@uyarn
Copy link
Collaborator Author

uyarn commented May 16, 2024

.@{prefix}-is--progress 也存在这个样式问题

@Except10n --progress? 截个图看看?

@uyarn uyarn merged commit 9dfe4af into develop May 16, 2024
7 checks passed
@uyarn uyarn deleted the fix/upload-image-error branch May 16, 2024 03:47
@uyarn
Copy link
Collaborator Author

uyarn commented May 16, 2024

@Except10n 麻烦有空回复下

@Except10n
Copy link

@uyarn

奇怪 复现不出来了,
.t-image__error .t-image__loading 两个样式错位的bug是一样的, 不知道为什么现在loading的情况不会发生

@uyarn
Copy link
Collaborator Author

uyarn commented May 16, 2024

@uyarn

奇怪 复现不出来了, .t-image__error .t-image__loading 两个样式错位的bug是一样的, 不知道为什么现在loading的情况不会发生

我修复的位置是他们父节点噢 如果还有问题你再另外提个issue吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants