-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Button): eventHandlercatch is changed to bind #1988
Open
anlyyao
wants to merge
1
commit into
develop
Choose a base branch
from
fix/button/event
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -4 B (0%) Total Size: 179 kB
ℹ️ View Unchanged
|
LeeJim
requested changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样 button 绑定的 tap 会触发两次?
catch会导致无法触发 navigator 的事件,所以改用了 bind,bindtap后意外发现自定义组件的tap事件被触发事件2次,怀疑是同名引起 |
Size Change: +4 B (0%) Total Size: 180 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #1978
fix #2025
fix #2329
fix #3358
💡 需求背景和解决方案
背景:navigator组件嵌套 t-button 时,无法跳转
方案:button 的 EventHandle从 catch 改为 bind
原因: catch会导致无法触发 navigator 的事件
📝 更新日志
fix(Button): 修复
navigator
组件嵌套t-button
时无法跳转的问题feat(Button): 新增 click事件
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单