Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rate): rate组件升级 #493

Merged
merged 3 commits into from
Nov 11, 2024
Merged

feat(rate): rate组件升级 #493

merged 3 commits into from
Nov 11, 2024

Conversation

ming680
Copy link
Contributor

@ming680 ming680 commented Aug 23, 2024 •
edited by anlyyao
Loading

rate组件升级

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #462

💡 需求背景和解决方案

📝 更新日志

  • feat(Rate): 组件重构，废弃 variant 属性， 新增 placement 与 icon 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

HaixingOoO
HaixingOoO reviewed Sep 9, 2024
View reviewed changes
src/rate/Rate.tsx Outdated Show resolved Hide resolved
HaixingOoO
HaixingOoO reviewed Sep 9, 2024
View reviewed changes
src/rate/Rate.tsx Outdated Show resolved Hide resolved
HaixingOoO
HaixingOoO reviewed Sep 9, 2024
View reviewed changes
src/rate/Rate.tsx Outdated Show resolved Hide resolved
HaixingOoO
HaixingOoO reviewed Sep 9, 2024
View reviewed changes
src/rate/Rate.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

完成

anlyyao
anlyyao reviewed Sep 18, 2024
View reviewed changes
src/rate/Rate.tsx Outdated Show resolved Hide resolved
src/rate/rate.md Outdated Show resolved Hide resolved
src/rate/rate.en-US.md Show resolved Hide resolved
src/rate/RateTips.tsx Outdated Show resolved Hide resolved
anlyyao
anlyyao reviewed Sep 18, 2024
View reviewed changes
src/rate/Rate.tsx Outdated Show resolved Hide resolved
@anlyyao anlyyao merged commit b7535d4 into Tencent:develop Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaixingOoO HaixingOoO HaixingOoO left review comments

@anlyyao anlyyao anlyyao approved these changes

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

@jarmywang jarmywang Awaiting requested review from jarmywang jarmywang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【Rate组件升级】任务单
3 participants
@ming680 @anlyyao @HaixingOoO