Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): add param named firstError #1320

Merged
merged 4 commits into from
Apr 19, 2024
Merged

fix(form): add param named firstError #1320

merged 4 commits into from
Apr 19, 2024

Conversation

KYSpring
Copy link
Collaborator

@KYSpring KYSpring commented Apr 18, 2024

form组件onSubmit回调补充firstError参数

fix #1302

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1302

💡 需求背景和解决方案

onSubmit参数对齐使用文档:

TS 类型:(context: SubmitContext) => void
表单提交时触发。其中 context.validateResult 表示校验结果,context.firstError 表示校验不通过的第一个规则提醒。
context.validateResult 值为 true 表示校验通过;如果校验不通过,context.validateResult 值为校验结果列表。

📝 更新日志

  • fix(Form): submit 事件补齐 firstError 参数

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

form组件onSubmit回调补充firstError参数

fix #1302
Copy link
Contributor

github-actions bot commented Apr 18, 2024

完成

Copy link
Contributor

Size Change: +274 B (0%)

Total Size: 438 kB

Filename Size Change
./dist/tdesign.js 233 kB +189 B (0%)
./dist/tdesign.min.js 137 kB +85 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 38.6 kB
./dist/tdesign.min.css 28.1 kB

src/form/form.vue Outdated Show resolved Hide resolved
src/form/form.vue Outdated Show resolved Hide resolved
Copy link
Contributor

Size Change: +188 B (0%)

Total Size: 438 kB

Filename Size Change
./dist/tdesign.js 233 kB +215 B (0%)
./dist/tdesign.min.js 137 kB -27 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 38.6 kB
./dist/tdesign.min.css 28.1 kB

Copy link
Contributor

Size Change: -362 B (0%)

Total Size: 437 kB

Filename Size Change
./dist/tdesign.js 233 kB -86 B (0%)
./dist/tdesign.min.js 137 kB -276 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 38.6 kB
./dist/tdesign.min.css 28.1 kB

Copy link
Contributor

Size Change: -194 B (0%)

Total Size: 437 kB

Filename Size Change
./dist/tdesign.js 233 kB +32 B (0%)
./dist/tdesign.min.js 137 kB -226 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 38.6 kB
./dist/tdesign.min.css 28.1 kB

@anlyyao anlyyao merged commit 40d6b4f into develop Apr 19, 2024
8 checks passed
@anlyyao anlyyao deleted the fix_form branch April 19, 2024 02:52
@github-actions github-actions bot mentioned this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vue3 移动端组件] form组件的submit方法缺少参数
2 participants