fix(popup): fix ref types #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricinix
requested review from
honkinglin,
uyarn and
carolin913
as code owners
|
|
uyarn
approved these changes
Nov 1, 2023
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix popup ref types
🤔 这个 PR 的性质是？
🔗 相关 Issue
问题比较小，就不另外提 issue 了，直接修复下。
💡 需求背景和解决方案
之前那个 pr，提交信息忘记脱敏了。用这个吧
PopupRef 的方法只定义了三个，然而实际上有五个。这里帮补充一下。
另外 PopupRef 的方法注释原本是用 // 的，这样会导致在调用时不能鼠标 hover 时显示出来。现改为 /** */。
📝 更新日志
fix(Popup): 修复PopupRef的类型缺失问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单