Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supportRef函数 判断条件错误修复 #2654

Closed
wants to merge 1 commit into from
Closed

fix: supportRef函数 判断条件错误修复 #2654

wants to merge 1 commit into from

Conversation

chrislol98
Copy link
Contributor

@chrislol98 chrislol98 commented Dec 11, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. 函数组件forwardRef, 他的type里面才有render, prototype里面好像没有render,这样永远返回false

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

完成

@@ -5,7 +5,7 @@ export function supportRef(nodeOrComponent: any): boolean {
const type = isMemo(nodeOrComponent) ? nodeOrComponent.type.type : nodeOrComponent.type;

// Function component node
if (typeof type === 'function' && !type.prototype?.render) {
if (typeof type === 'function' && !type?.render) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但是 class component 呢?还有别的原因必须修改这个吗

@chrislol98 chrislol98 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants