Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): collapsedItems's parameter collapsedSelectedItems #3214

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Nov 18, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

对于 #3185 pr 的修复

📝 更新日志

  • fix(Select): 修复 collapsedItems 的参数 collapsedSelectedItems

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@RSS1102
Copy link
Contributor Author

RSS1102 commented Nov 18, 2024

todo: collapsedSelectedItems test

Copy link
Contributor

github-actions bot commented Nov 18, 2024

失败

@RSS1102
Copy link
Contributor Author

RSS1102 commented Nov 20, 2024

增加两项测试

  1. 默认全选: 检测多选状态下自定义折叠项内容和自定义折叠项的弹出层内的自定义 tags。
  2. 默认无选择: 检测每次点击 select 弹层选择 option 后的效果。

Warning

2. 中选择数据顺序 为 options[0]options[2]options[1] 以测试自定义折叠项的弹出层内的自定义 tags 内容分别为 options[2].labeloptions[1].label (依照选中数据的先后顺序展示)。

@RSS1102 RSS1102 marked this pull request as ready for review November 20, 2024 19:33
@uyarn
Copy link
Collaborator

uyarn commented Nov 25, 2024

CI错误是日期选择器增加多选需求的报错 会在 #3199 中解决

@uyarn uyarn merged commit d1fde90 into Tencent:develop Nov 25, 2024
5 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants