Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): 多选下拉框全选功能失效 #3216

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

huangchen1031
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#3212

💡 需求背景和解决方案

1、处理onCheckAllChange方法中getSelectedOptions返回空的问题
2、将入参values从SelectOption[]修改为SeletValue[]

📝 更新日志

  • fix(select): 多选下拉框全选功能失效

  • [] 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Nov 19, 2024

完成

@uyarn
Copy link
Collaborator

uyarn commented Nov 20, 2024

方便的话 再补充个单测避免再次因为迭代失效了

@huangchen1031
Copy link
Collaborator Author

方便的话 再补充个单测避免再次因为迭代失效了

已添加

@uyarn uyarn merged commit 6746eb5 into Tencent:develop Nov 22, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants