-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): fix submenu parent item active status on mounted #3357
base: develop
Are you sure you want to change the base?
Conversation
src/menu/submenu.tsx
Outdated
|
||
export default defineComponent({ | ||
name: 'TSubmenu', | ||
name: submenuName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的名字改的我有点慌,曾经这里也写的是变量,但是打包后,失效了
然后有一次,就全部重新改成字符串了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方还是字符串没变 是方便后面取该组件使用
break; | ||
} | ||
node = node?.parent; | ||
} | ||
const activeValue = menu?.activeValue.value; | ||
if (activeValue !== props.value && mode.value === 'popup') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的代码板块理解过于复杂,建议定义单独的函数分别计算
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
修复前
修复后
MenuItem
在初始化时会被加入vMenu
的上下文中,由于此场景下,选中菜单在一开始并没有被初始化,所以需要手动加入vMenu
中📝 更新日志
fix(Menu): 修复
mode
为popup
的多级菜单场景下,选中菜单项在叶子节点时父级菜单初始化没有正确展示高亮效果的缺陷本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单