Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): onInputChange miss callback second parameters #3427

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Dec 18, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

17344910766554

📝 更新日志

  • fix(select): onInputChange 事件丢失第二个回调参数

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Dec 18, 2024

完成

@RSS1102
Copy link
Contributor Author

RSS1102 commented Dec 21, 2024

Recording.2024-12-22.024316.mp4

看起来这里在选中的时候会有一次抖动

@RSS1102 RSS1102 marked this pull request as draft December 26, 2024 19:51
@RSS1102 RSS1102 marked this pull request as ready for review December 27, 2024 03:26
@RSS1102
Copy link
Contributor Author

RSS1102 commented Dec 27, 2024

Recording.2024-12-22.024316.mp4
看起来这里在选中的时候会有一次抖动

这个看起来应该做为单独的新问题进行处理和本次 pr 无关

@uyarn uyarn merged commit 47d555d into Tencent:develop Dec 28, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
16 tasks
uyarn added a commit that referenced this pull request Dec 30, 2024
* fix(select): `onInputChange` miss callback second parameters

* chore: complete params

* chore: fix lint

---------

Co-authored-by: Uyarn <[email protected]>
uyarn added a commit that referenced this pull request Dec 30, 2024
* fix(upload): 上传组件图片展示样式优化 (#3429)

* fix(upload): 上传组件图片展示样式优化

* chore: update snapshot

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: radio options support radio button (#3402)

* docs: add readonly in api

* feat(RadioGroup): 单选组使用options时 支持button 模式

* fix(Dialog): fix closeOnOverlayClick default behavior (#3433)

* fix(cascader): change event is triggered unexpectedly when value-type is full (#3435)

* fix(cascader): verify invalid value logic errors and optimize code (#3438)

* feat(radio): support readonly (#3431)

* feat(radio): support readonly

* docs: api update

* feat(Table): support rows highlight  (#3442)

* feat(Table): support row highlight

* chore: update snapshot

* chore: update snapshot

* chore: update snapshot

* fix(PR_COMMENT_CI): resolve auto conflicts (#3443)

* fix(select): `onInputChange` miss callback second parameters (#3427)

* fix(select): `onInputChange` miss callback second parameters

* chore: complete params

* chore: fix lint

---------

Co-authored-by: Uyarn <[email protected]>

* fix(select): `checkAll` will check all filtered data of `reserveKeyword` (#3440)

* perf(select): `checkAll` will check all to keep the filtered data of `reserveKeyword`

* chore: remove unuse code

* chore(deps):  upgrade vitest 2.1.8 (#3424)

* chore(deps):  upgrade vitest 2.1.8

* chore: use @vitest/coverage-v8

* chore: update snapshot

* chore: fix

* chore: fix

* chore: update snapshot

* chore: update snapshot

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* perf(select): support rendering children when `group` title is not exist  (#3445)

* feat(attach): support global attach config (#3437)

* feat: support global config attach

* chore: update common

* chore: api update

* fix: test

* fix: test

* chore: update snapshot

* chore: clear typograph  code

* chore: clear typograph  code

* chore: revert irrelevant docs change

* feat: fix config

* feat: fix config

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Uyarn <[email protected]>

* chore: release 1.10.8 (#3447)

* chore: release 1.10.8

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: release 1.10.8-naruto

---------

Co-authored-by: huangchen1031 <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: myron <[email protected]>
Co-authored-by: betavs <[email protected]>
Co-authored-by: liweijie0812 <[email protected]>
Co-authored-by: 阿菜 Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants