Add a python script to observe the relationship between stream offset and time #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #375 +/- ##
========================================
Coverage 95.22% 95.22%
========================================
Files 50 50
Lines 33941 33941
========================================
+ Hits 32319 32321 +2
+ Misses 1622 1620 -2 ☔ View full report in Codecov by Sentry. |
iyangsj
requested changes
Aug 27, 2024
tools/script/streamoffset_time.py
Outdated
|
|
||
| # Set up the command line argument parser | ||
| parser = argparse.ArgumentParser(description='Analyze TQUIC logs to get the relationship between stream offset and time.') | ||
| parser.add_argument('log_file', type=str, help='Path to the TQUIC log file') |
There was a problem hiding this comment.
以上三个参数，增加 required=true 属性，要求必须指定参数，否则会报错并输出帮助信息
| @@ -0,0 +1,63 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
使用格式化工具black格式化代码：
python3 -m black <source_dir>
注：安装方式
pip install black --break-system-packages
| parser.add_argument('connection_trace_id', type=str, help='Connection trace id, eg. SERVER-c6d45bc005585f42') | ||
| parser.add_argument('stream_id', type=int, help='Stream id, eg. 0') | ||
| args = parser.parse_args() | ||
|
|
There was a problem hiding this comment.
line 9～ line14 移动到line60 main 函数中
tools/script/streamoffset_time.py
Outdated
| continue | ||
|
|
||
| connection_stream_frame_match = connection_stream_pattern.search(line) | ||
| if connection_stream_frame_match: |
There was a problem hiding this comment.
减少不必要的缩进
if not connection_stream_frame_match
continue
...
tools/script/streamoffset_time.py
Outdated
| connection_stream_pattern = re.compile(r'{} sent packet OneRTT.*?STREAM id={} off=(\d+) len=\d+ fin=(?:true|false)'.format(cid, stream_id)) | ||
|
|
||
| for line in log_data: | ||
|
|
tools/script/streamoffset_time.py
Outdated
| plt.xlabel('Time') | ||
| plt.ylabel('Stream Offset') | ||
| plt.title(f'Stream {stream_id} Offset by Time in Connection {cid}') | ||
| plt.gca().xaxis.set_major_formatter(plt.matplotlib.dates.DateFormatter('%H:%M:%S')) |
There was a problem hiding this comment.
X 轴显示的时间，增加毫秒，避免短流（例如 1s 内）无法显示有效时间信息
tools/script/streamoffset_time.py
Outdated
| plt.ylabel('Stream Offset') | ||
| plt.title(f'Stream {stream_id} Offset by Time in Connection {cid}') | ||
| plt.gca().xaxis.set_major_formatter(plt.matplotlib.dates.DateFormatter('%H:%M:%S')) | ||
| #plt.show() |
| plt.savefig(output_file_name) | ||
|
|
||
| if __name__ == '__main__': | ||
|
|
| @@ -0,0 +1,63 @@ | |||
| #!/usr/bin/env python3 | |||
|
|
|||
There was a problem hiding this comment.
增加如下文件说明，前后各空一行
# This tool is used to analyze TQUIC debug logs and produce a time-offset figure
# for the specified QUIC stream.
tools/script/streamoffset_time.py
Outdated
|
|
||
| # Set up the command line argument parser | ||
| parser = argparse.ArgumentParser(description='Analyze TQUIC logs to get the relationship between stream offset and time.') | ||
| parser.add_argument('log_file', type=str, help='Path to the TQUIC log file') |
There was a problem hiding this comment.
‘Path to the TQUIC log file’ --> 'Path to the TQUIC debug log file'
提示明确说明是 debug 级别日志，否则用户可能发现无法正确绘图
iyangsj
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a python script to observe the relationship between stream offset and time