Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: such response type should just return themself not return a string #622

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lianghx-319
Copy link

@lianghx-319 lianghx-319 commented May 12, 2023

Why

When my application load .wasm file from xhr, method getResonseByResponseType make respone become a string. I think just return the origin response is make sense.

@tencent-adm
Copy link
Member

tencent-adm commented May 12, 2023

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Maizify
Copy link
Collaborator

Maizify commented May 22, 2023

For a non-string response, it may not be displayed correctly on HTML, so I converted it to a string. If the original response is returned directly, how to ensure that it is displayed correctly in HTML?

@Maizify Maizify added the Details wanted Need more details label May 22, 2023
@lianghx-319
Copy link
Author

For a non-string response, it may not be displayed correctly on HTML, so I converted it to a string. If the original response is returned directly, how to ensure that it is displayed correctly in HTML?

But when I request a wasm file, this proxy will make wasm init fail, because the response changed.

@Madar119 Madar119 mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Details wanted Need more details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants