Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape quotemarks in Tree (and JSON copied) #678

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

satouriko
Copy link

BUG: when logging an object in which strings includes quotemark, for eg.

console.log({ a: 'asdfdsa"as\ndfdsf"df' })

displays & copies an invalid json: {"a": "asdfdsa"as\ndfdsf"df"}

The pull request proposes an attempt to fix that issue. It is changed to {"a": "asdfdsa\"as\ndfdsf\"df"}

Meanwhile, behavior logging a string should not be change:

console.log('asdfdsa"as\ndfdsf"df')

displays & copies

asdfdsa"as
dfdsf"df

@tencent-adm
Copy link
Member

tencent-adm commented May 29, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants