-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix release master #7594
Merged
normal-wls
merged 8 commits into
TencentBlueKing:feature_ip_selector_master
from
guohelu:hotfix_release_master
Oct 31, 2024
Merged
Hotfix release master #7594
normal-wls
merged 8 commits into
TencentBlueKing:feature_ip_selector_master
from
guohelu:hotfix_release_master
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntBlueKing/bk-sops into hotfix_release_master # Conflicts: # gcloud/tests/utils/cmdb/test_business_host_topo.py # gcloud/utils/cmdb.py # pipeline_plugins/cmdb_ip_picker/query.py
normal-wls
requested changes
Oct 29, 2024
@@ -219,7 +219,10 @@ def cmdb_search_host(request, bk_biz_id, bk_supplier_account="", bk_supplier_id= | |||
host_lock_status = host_lock_status_data.get(host_detail["bk_host_id"]) | |||
if host_lock_status is not None: | |||
host_detail["bk_host_lock_status"] = host_lock_status | |||
result = {"result": True, "code": NO_ERROR, "data": data} | |||
if count: | |||
result = {"result": True, "code": NO_ERROR, "data": {"data": data, "count": count}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里涉及返回两套协议,前端需要自己判断如何处理?
normal-wls
requested changes
Oct 30, 2024
guohelu
force-pushed
the
hotfix_release_master
branch
from
October 30, 2024 10:46
e46b431
to
ad1bcbf
Compare
guohelu
force-pushed
the
hotfix_release_master
branch
from
October 31, 2024 02:23
dae64e6
to
bedd6cd
Compare
normal-wls
requested changes
Oct 31, 2024
normal-wls
approved these changes
Oct 31, 2024
normal-wls
merged commit Oct 31, 2024
d0c7abd
into
TencentBlueKing:feature_ip_selector_master
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.