Add color theme pokemon-go #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! It looks like you added the theme to the CSS file, but not to If you need assistance, you can find a guide on the full process here: https://dev.to/tvanblargan/make-your-first-pull-request-3iai Drop a comment once that's updated and I'll remove the invalid tag + merge 😄 |
|
Sorry for that! I've updated it now and git pushed, please let me know if there are any more issues. Thank you for your patience! |
|
I'm seeing the theme now, however it's currently not WCAG compliant. If you could update the theme so that the 3 sentences in the "A11y" card show as AA or AAA complaint, I can merge your theme in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to Issue #12
Screenshot of my A11y card:
For assistance: https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests