add paper theme #94
Closed
add paper theme #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is a great start, but currently the header doesn't have enough contrast between the text and background color. If you could update that and ping me in a comment here once updated, I can approve the PR and merge it in 😄 |
|
Do you mean the text color is too similar to the link color? @12vanblart |
|
The contrast between the Header text color and the Header background color is too low, so users may have a hard time being able to read the words. You can find more about contrast here: https://webaim.org/resources/contrastchecker/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot of my A11y card:
For assistance: https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests