New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alert): add adjustHeight #2409

Open

ObedVega wants to merge 2 commits into Teradata:main from ObedVega:fix/alert-height

ObedVega commented Feb 12, 2025 •

edited

Loading

Description

Improved the responsiveness of the Alert Banner by dynamically adjusting its height based on different screen widths.

What's included?

Dynamic height adjustment for screen widths ≤ 430px and ≤ 768px.

Test Steps

Resize the browser window to ≤ 430px and confirm the banner adjusts its height correctly.
Resize to 431px–768px and verify the adjusted height remains consistent.
Test on desktop resolutions (> 768px) to ensure the height resets properly.

General Tests for Every PR

npm run start still works.
npm run lint passes.
npm run stylelint passes.
npm test passes and code coverage is not lower.
npm run build still works.

Screenshots or link to StackBlitz/Plunker

Vega added 2 commits

February 12, 2025 10:43


          fix(alert): add adjustHeight

674c3f6


          fix(alert): add adjustHeight when content updates

2c84dfe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet