fix(components): adjusting the height layout of alert on resize #2420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the
AlertBase
class in thelibs/components/src/alert/alert-base.ts
file to enhance its functionality and maintainability. The most important changes include adding aResizeObserver
to handle element resizing, updating therender
method for better readability, and minor code formatting improvements.What's included?
ResizeObserver
to theAlertBase
class to observe and handle element resizing. This includes initializing the observer in the constructor, updating thecurrentWidth
state, and handling cleanup in thedisconnectedCallback
method. [1] [2]Test Steps
npm run storybook
General Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to StackBlitz/Plunker
Uploading Screen Recording 2025-02-13 at 10.30.18 AM.mov…