Switch from Maven to Gradle #1194
Open
+5,439
−8,497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
force-pushed
the
gradle
branch
8 times, most recently
from
52cb879 to
64f9505
Compare
mathieucarbou
force-pushed
the
gradle
branch
8 times, most recently
from
eddec39 to
713dd08
Compare
mathieucarbou
force-pushed
the
gradle
branch
13 times, most recently
from
e8143f0 to
3029fee
Compare
mathieucarbou
force-pushed
the
gradle
branch
4 times, most recently
from
5783198 to
2fc8f03
Compare
mathieucarbou
force-pushed
the
gradle
branch
6 times, most recently
from
2ed848d to
22a120c
Compare
mathieucarbou
force-pushed
the
gradle
branch
from
22a120c to
b5f2a39
Compare
mathieucarbou
commented
Dec 19, 2024
Comment on lines
+40
to
+45
| LicenseService licenseService = findService(platformConfiguration, LicenseService.class); | ||
| if(licenseService == LicenseService.UNSUPPORTED) { | ||
| // no license service, no data roots | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Such check allow to have common layout between EE and OSS but only apply resources (or eventually services) when a license service is there
mathieucarbou
force-pushed
the
gradle
branch
6 times, most recently
from
9fd3a1c to
f141d31
Compare
|
@chrisdennis : gradle migration is finished, build pass locally. For now, the build runs through GitHub workflow (see link in my fork above), because I have a control over that). We could decide to do a mix between building with GithHub or Azure and then deploying with Azure. The only part remaining is then the CI part with Azure if we keep it, I just don't know which project to take as example. Or should we for example do something like that: https://github.com/Terracotta-OSS/terracotta-utilities/blob/master/build.gradle.kts#L28-L57 |
mathieucarbou
force-pushed
the
gradle
branch
5 times, most recently
from
bdafc7b to
7364fbd
Compare
mathieucarbou
force-pushed
the
gradle
branch
from
7364fbd to
759c4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster-topologyintomanagement-model)settings.gradle)CI result can be seen at: https://github.com/mathieucarbou/terracotta-platform/actions
Requires: Terracotta-OSS/terracotta-gradle-plugins#31