Close #171: Failover support on server side #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
force-pushed
the
issue-171
branch
4 times, most recently
from
38e9223 to
772d77a
Compare
mathieucarbou
changed the title
mathieucarbou
force-pushed
the
issue-171
branch
from
772d77a to
25a8ae4
Compare
mathieucarbou
requested review from
GaryWKeim
and removed request for
ChrisGreenaway
anthonydahanne
approved these changes
Dec 15, 2016
There was a problem hiding this comment.
LGTM - few assertions, but they will be added with Galvan testing work, in #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the monitoring service supports failover and detect when entities are transitioning from passive state to active state.
The transition is recorded, and when the new monitoring tree is built and new active entities are created, if this entity was passive before, then a
SERVER_ENTITY_FAILOVER_COMPLETEDevent is sent with the entity context.It is possible that the TMS does not get these notifications if the tms entity does not reconnect BEFORE the other ones.
WARNING
With passthrough, platform does not send the right events to us after a failover, when client reconnects and when new active entities are created. So there's a lot of notification that I do not have and I cannot assert them because the monitoring tree is not reconstructed as it should be.
I placed some
TODOin the project for the tests that needs to be also done ASAP with Galvan (#191)