-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax highlighting to searches #498
base: 1.19.3
Are you sure you want to change the base?
Add syntax highlighting to searches #498
Conversation
This is really cool! I'm worried about the change of search behavior though. We need to teach users to prepend the |
Ideally, the syntax highlighting would be supplanted by suggestions akin to commands. The library button could also just add or remove I think this change actually improves discovery overall. Previously, adding a filter was easy to do accidentally and could even hide mods that would otherwise match the search terms. Now, a correct search term is prefixed by the In the end, search terms are a power user tool and I think that after the proposed changes, their discoverability will be suitable. |
This is a really cool feature! I have one question though: Is the usage of |
It's like |
Selectors in a command aren't really the same as tags in a search though. I'm looking at this from the perspective of someone who's used to search engines like twitter or mastodon where terms/categories/concepts use #tags and individuals use @Handles . Using command syntax for something that's not a command, to filter for things that are not selectors, is just going to confuse matters. If you really want to lean into the command-like syntax, then you shouldn't have searches like |
This pull request refactors the search functionality to allow for more dynamic and highlighted searches. In particular, keywords must now be prefixed with
@
, and complete keywords will be colored to match their badge if they are associated with one.In the future, these changes can be used to make various other improvements possible, including:
-@library
to match non-library mod)"Mod Menu"
to matchmod menu
but notmod
ormenu
)@author:Prospector
to match mods authored by Prospector)