Fix build_admin and build_front on Mac #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 79 79
Lines 2848 2848
=======================================
Hits 2705 2705
Misses 143 143
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bo-Duke
commented
Nov 10, 2023
| @@ -2,8 +2,10 @@ | |||
|
|
|||
| SHELL = /bin/sh | |||
|
|
|||
| CURRENT_UID := $(shell id -u) | |||
| CURRENT_UID := $(shell id -g) | |||
| ifndef mac | |||
There was a problem hiding this comment.
@submarcos That's the cleanest way I found to do it.
On mac, the commands should be called like this make build_admin mac=true or make build_front mac=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify users in make_file