Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate code in gulpfile and fixup helm files #666

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

tephenavies
Copy link
Member

@tephenavies tephenavies commented Apr 10, 2024

  • Improve helm files
  • Use terriajs-server gulp task from terriajs

I moved the "terriajs-server" gulp task to a separate file in the terriajs repo so that TerriaMap and terriajs could use the same code to run terriajs-server (with a different default port). This is to reduce code duplication.

Copy link
Contributor

@staffordsmith83 staffordsmith83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine

@tephenavies tephenavies merged commit f5f00f6 into main Apr 18, 2024
6 checks passed
@tephenavies tephenavies deleted the small-improvements branch April 18, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants