Skip to content

Commit

Permalink
Merge pull request #6986 from TerriaJS/use-node-v16
Browse files Browse the repository at this point in the history
Update minimum supported node version to v16
  • Loading branch information
ljowen authored Nov 30, 2023
2 parents 14e8239 + 3ff4b86 commit 179805f
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2

- uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: "14.x"
node-version-file: ".nvmrc"
- run: npm install -g yarn@^1.19.0 && yarn install

- name: Check formatting with prettier
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: "14.x"
node-version-file: ".nvmrc"
- uses: google-github-actions/[email protected]
with:
service_account_key: ${{ secrets.GCP_CREDENTIALS }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ jobs:

- name: Set up Node.js for NPM
if: steps.detect.outputs.previous-version != steps.detect.outputs.current-version
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
registry-url: "https://registry.npmjs.org"
node-version: "14.x"
node-version-file: ".nvmrc"

- name: Install yarn
if: steps.detect.outputs.previous-version != steps.detect.outputs.current-version
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v16.20.2
2 changes: 1 addition & 1 deletion buildprocess/ci-deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ gh api /repos/${GITHUB_REPOSITORY}/statuses/${GITHUB_SHA} -f state=pending -f co

# Install some tools we need from npm
npm install -g https://github.com/terriajs/sync-dependencies
npm install request@^2.83.0
npm install -g yarn@^1.19.0
yarn add -W [email protected]

# Clone and build TerriaMap, using this version of TerriaJS
TERRIAJS_COMMIT_HASH=$(git rev-parse HEAD)
Expand Down
4 changes: 2 additions & 2 deletions doc/customizing/cloning-and-building.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ If you run into trouble or want more explanation, read on.
TerriaJS can be built and run on almost any macOS, Linux, or Windows system. The following are required to build TerriaJS:

- The Bash command shell. On macOS or Linux you almost certainly already have this. On Windows, you can easily get it by installing [Git for Windows](https://gitforwindows.org/). In the instructions below, we assume you're using a Bash command prompt.
- [Node.js](https://nodejs.org) v14.0 or later. You can check your node version by running `node --version` on the command-line.
- [npm](https://www.npmjs.com/) v6.0 or later. npm is usually installed automatically alongside the above. You can check your npm version by running `npm --version`.
- [Node.js](https://nodejs.org) v16.0. You can check your node version by running `node --version` on the command-line.
- [npm](https://www.npmjs.com/) v8.0. npm is usually installed automatically alongside the above. You can check your npm version by running `npm --version`.
- [yarn](https://yarnpkg.com/) v1.19.0 or later. This can be installed using `npm install -g yarn@^1.19.0`

### Cloning TerriaMap
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Geospatial data visualization platform.",
"license": "Apache-2.0",
"engines": {
"node": ">= 14.0.0"
"node": ">= 16.0.0"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 179805f

Please sign in to comment.