Merge pull request #7126 from pjonsson/unused-consts

Remove unused variables
TerriaJS · Jun 26, 2024 · 87b57b0 · 87b57b0
2 parents 37419b5 + 5128e81
commit 87b57b0
Show file tree

Hide file tree

Showing 12 changed files with 3 additions and 82 deletions.
diff --git a/buildprocess/directory-loader.js b/buildprocess/directory-loader.js
diff --git a/gulpfile.js b/gulpfile.js
@@ -54,7 +54,7 @@ gulp.task("lint", function (done) {
     "--ignore-pattern",
     "lib/ThirdParty",
     "--max-warnings",
-    "264" // TODO: Bring this back to 0
+    "238" // TODO: Bring this back to 0
   ]);
 
   done();

diff --git a/lib/Map/ColorMap/EnumColorMap.ts b/lib/Map/ColorMap/EnumColorMap.ts
@@ -40,7 +40,6 @@ export default class EnumColorMap extends ColorMap {
     }
 
     const values = this.values;
-    let i, len;
     for (let i = 0, len = values.length; i < len; ++i) {
       if (values[i] === value) {
         return this.colors[i];

diff --git a/lib/Map/Leaflet/LeafletVisualizer.ts b/lib/Map/Leaflet/LeafletVisualizer.ts
@@ -1106,8 +1106,6 @@ function getDashArray(
   material: PolylineDashMaterialProperty,
   time: JulianDate
 ): number[] {
-  let dashArray;
-
   const dashPattern = material.dashPattern
     ? material.dashPattern.getValue(time)
     : undefined;

diff --git a/lib/Models/Catalog/Ckan/CkanCatalogGroup.ts b/lib/Models/Catalog/Ckan/CkanCatalogGroup.ts
@@ -117,8 +117,6 @@ export class CkanServerStratum extends LoadableStratum(CkanCatalogGroupTraits) {
   static async load(
     catalogGroup: CkanCatalogGroup
   ): Promise<CkanServerStratum | undefined> {
-    const terria = catalogGroup.terria;
-
     let ckanServerResponse: CkanServerResponse | undefined = undefined;
 
     // Each item in the array causes an independent request to the CKAN, and the results are concatenated

diff --git a/lib/Models/Catalog/Ckan/CkanItemReference.ts b/lib/Models/Catalog/Ckan/CkanItemReference.ts
@@ -520,7 +520,6 @@ export function isResourceInSupportedFormats(
   formats: PreparedSupportedFormat[]
 ): PreparedSupportedFormat | undefined {
   if (resource === undefined) return undefined;
-  const matches: PreparedSupportedFormat[] = [];
   for (let i = 0; i < formats.length; ++i) {
     const format = formats[i];
     if (resourceIsSupported(resource, format)) return format;

diff --git a/lib/Models/Catalog/Esri/ArcGisCatalogGroup.ts b/lib/Models/Catalog/Esri/ArcGisCatalogGroup.ts
@@ -68,7 +68,6 @@ class ArcGisServerStratum extends LoadableStratum(ArcGisCatalogGroupTraits) {
   static async load(
     catalogGroup: ArcGisCatalogGroup
   ): Promise<ArcGisServerStratum> {
-    const terria = catalogGroup.terria;
     const uri = new URI(catalogGroup.url).addQuery("f", "json");
     return loadJson(proxyCatalogItemUrl(catalogGroup, uri.toString()))
       .then((arcgisServer: ArcGisServer) => {

diff --git a/lib/Models/Catalog/Esri/ArcGisFeatureServerCatalogGroup.ts b/lib/Models/Catalog/Esri/ArcGisFeatureServerCatalogGroup.ts
@@ -120,7 +120,6 @@ export class FeatureServerStratum extends LoadableStratum(
   static async load(
     catalogGroup: ArcGisFeatureServerCatalogGroup | ArcGisCatalogGroup
   ): Promise<FeatureServerStratum> {
-    const terria = catalogGroup.terria;
     const uri = new URI(catalogGroup.url).addQuery("f", "json");
 
     return loadJson(proxyCatalogItemUrl(catalogGroup, uri.toString()))

diff --git a/lib/Models/Catalog/Esri/ArcGisPortalCatalogGroup.ts b/lib/Models/Catalog/Esri/ArcGisPortalCatalogGroup.ts
@@ -60,8 +60,6 @@ export class ArcGisPortalStratum extends LoadableStratum(
   static async load(
     catalogGroup: ArcGisPortalCatalogGroup
   ): Promise<ArcGisPortalStratum | undefined> {
-    const terria = catalogGroup.terria;
-
     let portalGroupsServerResponse:
       | ArcGisPortalGroupSearchResponse
       | undefined = undefined;

diff --git a/lib/ReactViews/StandardUserInterface/StandardUserInterface.tsx b/lib/ReactViews/StandardUserInterface/StandardUserInterface.tsx
@@ -129,8 +129,6 @@ const StandardUserInterfaceBase: React.FC<StandardUserInterfaceProps> =
       props.children
     );
 
-    const terria = props.terria;
-
     const showStoryBuilder =
       props.viewState.storyBuilderShown &&
       !props.viewState.useSmallScreenInterface;

diff --git a/lib/ReactViews/Workbench/Controls/DisplayAsPercentSection.tsx b/lib/ReactViews/Workbench/Controls/DisplayAsPercentSection.tsx
@@ -13,7 +13,7 @@ const DisplayAsPercentSection: React.FC<IDisplayAsPercentSection> = (
   props: IDisplayAsPercentSection
 ) => {
   const { t } = useTranslation();
-  const theme = useTheme();
+  useTheme();
   const togglePercentage = () => {
     props.item.displayPercent = !props.item.displayPercent;
   };

diff --git a/lib/Styled/Input.tsx b/lib/Styled/Input.tsx
@@ -126,7 +126,7 @@ export const StyledInput = styled.input<InputProps>`
 
 const Input: React.FC<InputProps> = (props: InputProps) => {
   const { boxProps, ...rest }: InputProps = props;
-  const theme: DefaultTheme = useTheme();
+  useTheme();
   return (
     <Box fullWidth {...boxProps}>
       <StyledInput {...rest} />