ESLint: enable @typescript-eslint/no-useless-constructor

Remove constructors that just call super() wtih their arguments and enable @typescript-eslint/no-useless-constructor.
TerriaJS · Oct 1, 2024 · d8a5e28 · d8a5e28
1 parent 803e50d
commit d8a5e28
Show file tree

Hide file tree

Showing 16 changed files with 4 additions and 76 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -36,6 +36,10 @@
     /* ban-types is split in ESLint v8:
        https://typescript-eslint.io/rules/ban-types/ */
     "@typescript-eslint/ban-types": "error",
+    /* The no-useless-constructor needs to be disabled for
+       the @typescript-eslint-rule. */
+    "no-useless-constructor": "off",
+    "@typescript-eslint/no-useless-constructor": "error",
     "@typescript-eslint/unified-signatures": "error",
     "react-hooks/exhaustive-deps": "error",
     "react/jsx-boolean-value": ["error", "never", { "always": [] }],

diff --git a/lib/Models/Catalog/CatalogReferences/ThreddsItemReference.ts b/lib/Models/Catalog/CatalogReferences/ThreddsItemReference.ts
@@ -3,17 +3,14 @@ import { runInAction } from "mobx";
 import ReferenceMixin from "../../../ModelMixins/ReferenceMixin";
 import UrlMixin from "../../../ModelMixins/UrlMixin";
 import ThreddsItemReferenceTraits from "../../../Traits/TraitsClasses/ThreddsItemReferenceTraits";
-import ModelTraits from "../../../Traits/ModelTraits";
 import ThreddsCatalogGroup, {
   ThreddsDataset
 } from "../CatalogGroups/ThreddsCatalogGroup";
 import CatalogMemberFactory from "../CatalogMemberFactory";
 import CreateModel from "../../Definition/CreateModel";
 import LoadableStratum from "../../Definition/LoadableStratum";
 import { BaseModel } from "../../Definition/Model";
-import StratumFromTraits from "../../Definition/StratumFromTraits";
 import StratumOrder from "../../Definition/StratumOrder";
-import Terria from "../../Terria";
 import WebMapServiceCatalogGroup from "../Ows/WebMapServiceCatalogGroup";
 
 export class ThreddsDatasetStratum extends LoadableStratum(
@@ -71,15 +68,6 @@ export default class ThreddsItemReference extends UrlMixin(
   _threddsDataset: ThreddsDataset | undefined = undefined;
   _threddsCatalogGroup: ThreddsCatalogGroup | undefined = undefined;
 
-  constructor(
-    id: string | undefined,
-    terria: Terria,
-    sourceReference?: BaseModel,
-    strata?: Map<string, StratumFromTraits<ModelTraits>>
-  ) {
-    super(id, terria, sourceReference, strata);
-  }
-
   setDataset(dataset: ThreddsDataset) {
     this._threddsDataset = dataset;
   }

diff --git a/lib/Models/Catalog/CatalogReferences/UrlReference.ts b/lib/Models/Catalog/CatalogReferences/UrlReference.ts
@@ -3,9 +3,7 @@ import UrlMixin from "../../../ModelMixins/UrlMixin";
 import CatalogMemberFactory from "../CatalogMemberFactory";
 import CreateModel from "../../Definition/CreateModel";
 import { BaseModel } from "../../Definition/Model";
-import StratumFromTraits from "../../Definition/StratumFromTraits";
 import Terria from "../../Terria";
-import ModelTraits from "../../../Traits/ModelTraits";
 import UrlReferenceTraits from "../../../Traits/TraitsClasses/UrlReferenceTraits";
 import StratumOrder from "../../Definition/StratumOrder";
 import CatalogMemberMixin from "../../../ModelMixins/CatalogMemberMixin";
@@ -23,15 +21,6 @@ export default class UrlReference extends UrlMixin(
     return UrlReference.type;
   }
 
-  constructor(
-    id: string | undefined,
-    terria: Terria,
-    sourceReference?: BaseModel,
-    strata?: Map<string, StratumFromTraits<ModelTraits>>
-  ) {
-    super(id, terria, sourceReference, strata);
-  }
-
   protected forceLoadReference(
     _previousTarget: BaseModel | undefined
   ): Promise<BaseModel | undefined> {

diff --git a/lib/Models/Catalog/Gtfs/GtfsRealtimeProtoBufReaders.ts b/lib/Models/Catalog/Gtfs/GtfsRealtimeProtoBufReaders.ts
@@ -29,10 +29,6 @@ export class FeedMessageReader extends ProtobufMessageReader<FeedMessage> {
     entity: []
   };
 
-  constructor() {
-    super();
-  }
-
   protected readField(tag: number, obj?: FeedMessage, pbf?: Pbf): void {
     if (pbf === null || pbf === undefined) {
       return;

diff --git a/lib/ReactViews/Disclaimer.jsx b/lib/ReactViews/Disclaimer.jsx
@@ -51,10 +51,6 @@ class Disclaimer extends React.Component {
     t: PropTypes.func.isRequired
   };
 
-  constructor(props) {
-    super(props);
-  }
-
   confirm(confirmCallbackFn) {
     if (confirmCallbackFn) {
       confirmCallbackFn();

diff --git a/lib/ReactViews/Map/MapNavigation/Items/MapNavigationItem.tsx b/lib/ReactViews/Map/MapNavigation/Items/MapNavigationItem.tsx
@@ -20,10 +20,6 @@ interface PropTypes {
 
 @observer
 class MapNavigationItemBase extends React.Component<PropTypes> {
-  constructor(props: PropTypes) {
-    super(props);
-  }
-
   render() {
     const { closeTool = true, item, expandInPlace, i18n } = this.props;
     if (item.render)

diff --git a/lib/ReactViews/Map/MapNavigation/Items/ZoomControl.tsx b/lib/ReactViews/Map/MapNavigation/Items/ZoomControl.tsx
@@ -31,10 +31,6 @@ export const ZOOM_CONTROL_ID = "zoom";
 class ZoomControlBase extends React.Component<PropTypes> {
   static displayName = "ZoomControl";
 
-  constructor(props: PropTypes) {
-    super(props);
-  }
-
   flyToPosition(
     scene: Scene,
     position: Cartesian3,

diff --git a/lib/ReactViews/Map/Panels/HelpPanel/HelpPanelItem.jsx b/lib/ReactViews/Map/Panels/HelpPanel/HelpPanelItem.jsx
@@ -26,10 +26,6 @@ class HelpPanelItem extends React.Component {
     i18n: PropTypes.object.isRequired
   };
 
-  constructor(props) {
-    super(props);
-  }
-
   render() {
     const { i18n } = this.props;
 

diff --git a/lib/ReactViews/Map/Panels/HelpPanel/HelpVideoPanel.jsx b/lib/ReactViews/Map/Panels/HelpPanel/HelpVideoPanel.jsx
@@ -34,10 +34,6 @@ class HelpVideoPanel extends React.Component {
     i18n: PropTypes.object.isRequired
   };
 
-  constructor(props) {
-    super(props);
-  }
-
   render() {
     const helpItemType = this.props.paneMode || "videoAndContent"; // default is video panel
     const itemSelected =

diff --git a/lib/ReactViews/Map/Panels/HelpPanel/StyledHtml.jsx b/lib/ReactViews/Map/Panels/HelpPanel/StyledHtml.jsx
@@ -51,10 +51,6 @@ export class StyledHtmlRaw extends React.Component {
     injectTooltips: true
   };
 
-  constructor(props) {
-    super(props);
-  }
-
   render() {
     const { viewState, injectTooltips, i18n } = this.props;
     const styledTextProps = this.props.styledTextProps || {};

diff --git a/lib/ReactViews/Map/Panels/HelpPanel/TrainerPane.jsx b/lib/ReactViews/Map/Panels/HelpPanel/TrainerPane.jsx
@@ -33,10 +33,6 @@ class TrainerPane extends React.Component {
     i18n: PropTypes.object.isRequired
   };
 
-  constructor(props) {
-    super(props);
-  }
-
   render() {
     const { content, i18n, viewState } = this.props;
     const { trainerItems, markdownText } = content;

diff --git a/lib/ReactViews/Map/Panels/HelpPanel/VideoGuide.jsx b/lib/ReactViews/Map/Panels/HelpPanel/VideoGuide.jsx
@@ -69,10 +69,6 @@ class VideoGuide extends React.Component {
     t: PropTypes.func
   };
 
-  constructor(props) {
-    super(props);
-  }
-
   render() {
     const backgroundOpacity = this.props.backgroundOpacity;
     const backgroundBlackOverlay =

diff --git a/lib/ReactViews/RelatedMaps/RelatedMaps.tsx b/lib/ReactViews/RelatedMaps/RelatedMaps.tsx
@@ -20,13 +20,6 @@ type PropTypes = WithViewState &
 
 @observer
 class RelatedMaps extends React.Component<PropTypes> {
-  /**
-   * @param {Props} props
-   */
-  constructor(props: PropTypes) {
-    super(props);
-  }
-
   render() {
     const t = this.props.t;
     const dropdownTheme = {

diff --git a/lib/Table/createLongitudeLatitudeFeaturePerId.ts b/lib/Table/createLongitudeLatitudeFeaturePerId.ts
@@ -119,8 +119,6 @@ class PreSampledPositionProperty {
 
   private allValuesAreTheSame = true;
 
-  constructor() {}
-
   getProperty() {
     if (this.allValuesAreTheSame) {
       return new ConstantPositionProperty(this.values[0]);

diff --git a/lib/Traits/Decorators/anyTrait.ts b/lib/Traits/Decorators/anyTrait.ts
@@ -22,10 +22,6 @@ export default function anyTrait(options: TraitOptions) {
 export class AnyTrait extends Trait {
   readonly decoratorForFlattened = computed.struct;
 
-  constructor(id: string, options: AnyTraitOptions, parent: any) {
-    super(id, options, parent);
-  }
-
   getValue(model: BaseModel): any {
     for (const stratum of model.strataTopToBottom.values()) {
       const stratumAny: any = stratum;

diff --git a/test/ModelMixins/SearchProviders/SearchProviderMixinSpec.ts b/test/ModelMixins/SearchProviders/SearchProviderMixinSpec.ts
@@ -9,10 +9,6 @@ class TestSearchProvider extends SearchProviderMixin(
 ) {
   type = "test";
 
-  constructor(uniqueId: string | undefined, terria: Terria) {
-    super(uniqueId, terria);
-  }
-
   public override logEvent = jasmine.createSpy();
   public override doSearch = jasmine
     .createSpy()