Handle invalid initial box position.

TerriaJS · Sep 5, 2023 · fb7be45 · fb7be45
1 parent 35de3ed
commit fb7be45
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/lib/ModelMixins/ClippingMixin.ts b/lib/ModelMixins/ClippingMixin.ts
@@ -186,14 +186,21 @@ function ClippingMixin<T extends AbstractConstructor<BaseType>>(Base: T) {
         const cartographic = Cartographic.fromCartesian(
           Matrix4.getTranslation(clippingPlanesOriginMatrix, new Cartesian3())
         );
-        cartographic.height = dimensions.z / 2;
-        position = Cartographic.toCartesian(
-          cartographic,
-          cesium.scene.globe.ellipsoid,
-          new Cartesian3()
-        );
+        // If the translation is at the center of the ellipsoid then this cartographic could be undefined.
+        // Although it is not reflected in the typescript type.
+        if (cartographic) {
+          cartographic.height = dimensions.z / 2;
+          position = Cartographic.toCartesian(
+            cartographic,
+            cesium.scene.globe.ellipsoid,
+            new Cartesian3()
+          );
+        }
       }
 
+      // Nothing we can do - assign to zero
+      position ??= Cartesian3.ZERO.clone();
+
       let hpr: HeadingPitchRoll | undefined;
       if (
         this.clippingBox.rotation.heading !== undefined &&