Wps results fix

[sixlighthouses]

Fix WPS duplicate

Fixes #6392

Workbench items were being duplicated when loaded from WPS results in share URL.
Added a check in models/Terria.ts when loading items to ensure duplicates are not added

Test me

Load this share URL http://ci.terria.io/wps-results-fix/#share=s-uCLMJuXtXBpFXvmJbBI4gE4rGUz

Two items should be loaded to the workbench

Checklist

• There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
• I've updated relevant documentation in doc/.
• I've updated CHANGES.md with what I changed.
• I've provided instructions in the PR description on how to test this PR.

[na9da]

Hey @sixlighthouses, that's some good sleuthing 🕵️ job.

The root cause is that our workbench implementation is not protected from duplicate items - that might need a rethink at some point.

The fix you made works, but I would suggest changing newItems to a Set<BaseModel> instead? It'll automatically guard against similar bugs in other code paths. You can then convert the set to array using [...newItems].

[sixlighthouses]

thanks @na9da a set is a nice solution will make that change

[na9da]

Hey @sixlighthouses, on another thought the better fix would be to make the set method for workbench.items sanitize its input by de-duplicating the input array. You could use the lodash uniq method to do that.

Sorry if you already started on the fix.

[sixlighthouses]

thanks @na9da updated the workbenches items set method

[na9da]

Looks good @sixlighthouses. I have just made a couple of comments.

[na9da]

I think the correct next release for this change is 8.3.2 (so after the timefilter bug fix).

terriajs/CHANGES.md

Lines 3 to 7 in 15d4686

	#### next release (8.3.2)
	- Fixed a bug when restoring timefilter from a share link having more than one imagery item with the same base URL (but different layer names).
	- [The next improvement]

[na9da]

Good to go 🚀