-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support time window query #6872
Merged
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
57250b3
Add time interval traits.
mwu2018 8849436
refactor
mwu2018 e6d067c
refactor
mwu2018 0e7fa5a
Add unit tests.
mwu2018 73ab838
Refactor
mwu2018 24142b3
Refactor. Not to specify current time in model dimensions.
mwu2018 796d230
Update doc.
mwu2018 f6f99c6
Update doc.
mwu2018 0d1f71b
Update based on review.
mwu2018 8c818e3
Refactor based on review.
mwu2018 f6b6d44
Simplified based on review.
mwu2018 8aac2b6
Remove unwanted import.
mwu2018 bd1cdef
Update doc.
mwu2018 ea01a46
Refactor
mwu2018 202da5e
Remove unwanted import.
mwu2018 3dad23b
Merge branch 'main' into support-time-interval
mwu2018 0de56ab
Rename trait.
mwu2018 619531c
Minor refactoring.
mwu2018 ef506f4
Refactor based on review.
mwu2018 aa9fd41
Merge branch 'main' into support-time-interval
mwu2018 5f781f7
Refactor to make use of @compute.
mwu2018 87b4380
Merge branch 'main' into support-time-interval
mwu2018 f5f69fb
Merge branch 'support-time-interval' of github.com:TerriaJS/terriajs …
mwu2018 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
getTimeParams()
needs to be a@computed
. This is because we are passing it as parameter to_createImageryProvider
which itself is a computed (memoized) object. But here,getTimeParams
returns a new object each time which will result in re-computing of_createImageryProvider
. This is an expensive operation. You can avoid this by converting it to something like@computed get timeParams() {...}
.To see this in action, open the network tab for both the before and after links and try changing the opacity. For the after link, see that changing the opacity results in network fetches, whereas the network tab is silent when doing this for the before link.