Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapserver Groups #6874

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Mapserver Groups #6874

merged 5 commits into from
Sep 8, 2023

Conversation

sixlighthouses
Copy link
Contributor

@sixlighthouses sixlighthouses commented Sep 7, 2023 •
edited
Loading

What this PR does

Fixes #536

Currently ArcGIS Mapservers group can only handle nesting groups 1 level deep. This PR adds a recursive check which will allow nesting to be as deep as defined by the Mapservice config.

Test me

http://ci.terria.io/issue-536/#clean&https://gist.githubusercontent.com/sixlighthouses/a4fd27b75f41638efe902fa29ddf2825/raw/9167cbe29e558c4be7a269d37fd8298464278866/test.json

image

Open Data Catalog and Click through the multi level groups under Planning Overlays -- as per image above

prior to this change no layers are displayed under the second level groups i.e Environment and Landscape

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@sixlighthouses sixlighthouses changed the title Issue 536 from Vic Digital Twin Mapserver Groups Sep 7, 2023
@sixlighthouses sixlighthouses marked this pull request as ready for review September 7, 2023 05:20
@nf-s nf-s self-assigned this Sep 7, 2023
nf-s
nf-s requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@nf-s nf-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this - it has been needed for a while!
I have two small comments

lib/Models/Catalog/Esri/ArcGisMapServerCatalogGroup.ts Outdated Show resolved Hide resolved
lib/Models/Catalog/Esri/ArcGisMapServerCatalogGroup.ts Show resolved Hide resolved
nf-s
nf-s approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@nf-s nf-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sixlighthouses sixlighthouses merged commit 4f419c5 into main Sep 8, 2023
5 checks passed
@sixlighthouses sixlighthouses deleted the issue-536 branch September 8, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nf-s nf-s nf-s approved these changes

Assignees

@nf-s nf-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sixlighthouses @nf-s