Merge pull request #281 from trwyant/trw_diag_return_value

Document that diag() returns false,
Test-More · Oct 25, 2023 · 3577385 · 3577385
2 parents 64f8573 + f5486c6
commit 3577385
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/Test2/Tools/Basic.pm b/lib/Test2/Tools/Basic.pm
@@ -41,6 +41,7 @@ sub diag {
     my $ctx = context();
     $ctx->diag( join '', grep { defined $_ } @_ );
     $ctx->release;
+    return 0;
 }
 
 sub note {
@@ -248,6 +249,8 @@ Fire off a failing test (a single Ok event). The name and diagnostics are option
 Write diagnostics messages. All items in C<@messages> will be joined into a
 single string with no separator. When using TAP, diagnostics are sent to STDERR.
 
+Returns false, so as to preserve failure.
+
 =item note(@messages)
 
 Write note-diagnostics messages. All items in C<@messages> will be joined into