Bug Fix: golangci-linter checks

TestInABox · Dec 5, 2022 · 2eb4b2d · 2eb4b2d
1 parent 4410368
commit 2eb4b2d
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 7 deletions.
diff --git a/Makefile b/Makefile
@@ -7,3 +7,6 @@ test:
 coverage: test
 	go tool cover -html=.coverage
 	go tool cover -func=.coverage
+
+lint:
+	golangci-lint run
diff --git a/common/call_test.go b/common/call_test.go
@@ -15,7 +15,7 @@ func Test_Common_HttpCall(t *testing.T) {
         Headers: http.Header{},
         Request: &http.Request{},
     }
-    if hc == nil {
-        t.Error("Unexpected nil")
+    if hc.Method != "test" {
+        t.Errorf("Failed to set method")
     }
 }
diff --git a/common/reply_test.go b/common/reply_test.go
@@ -12,7 +12,7 @@ func Test_Common_HttpReply(t *testing.T) {
         Status: common.HttpStatus_RouteNotHandled,
         Headers: http.Header{},
     }
-    if hr == nil {
-        t.Error("Unexpected nil")
+    if hr.Status != common.HttpStatus_RouteNotHandled {
+        t.Errorf("Failed to set Status")
     }
 }
diff --git a/router/router_test.go b/router/router_test.go
@@ -59,7 +59,7 @@ func Test_Router_Router(t *testing.T) {
         func(t *testing.T) {
             irt := router.New()
             if irt == nil {
-                t.Errorf("New generated a nil pointer")
+                t.Fatal("New generated a nil pointer")
             }
             if irt.RequestHandlers == nil {
                 t.Errorf("New did not create the route table")

diff --git a/service/service_test.go b/service/service_test.go
@@ -90,10 +90,13 @@ func TestService(t *testing.T) {
                     scenario.name,
                     func(t *testing.T) {
                         handler := service.ServiceHandler{}
-                        handler.Init(
+                        initErr := handler.Init(
                             scenario.name,
                             &common.BasicServerURI{},
                         )
+                        if initErr != nil {
+                            t.Errorf("Failed to initialize the service handler: %#v", initErr)
+                        }
 
                         parameters := scenario.setup(t)
 
@@ -157,13 +160,16 @@ func TestService(t *testing.T) {
                     scenario.name,
                     func(t *testing.T) {
                         handler := service.ServiceHandler{}
-                        handler.Init(
+                        initErr := handler.Init(
                             scenario.name,
                             &common.BasicServerURI{
                                 Protocol: "http",
                                 Host: "example.com",
                             },
                         )
+                        if initErr != nil {
+                            t.Errorf("Failed to initialize the service handler: %#v", initErr)
+                        }
 
                         parameters := scenario.setup(t)