perf: use diesel_async and improve queries #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This is now ready for review. |
Eldemarkki
suggested changes
Dec 20, 2023
Co-authored-by: Eetu Mäenpää <[email protected]>
Eldemarkki
reviewed
Dec 20, 2023
Eldemarkki
reviewed
Dec 20, 2023
Co-authored-by: Eetu Mäenpää <[email protected]>
Eldemarkki
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diesel has some issue on complex queries and therefore we have to rely on multiple queries in some cases.
Regardless of that this is still a massive improvement on the current implementation.
For example the endpoint
/users/@me/leaderboardsis sped up roughly by a factor of 37.before:
after:
The performance of
/friends/listis also drastically improved.