Serverside hidden activities #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajp
requested changes
Mar 15, 2024
|
Additionally would it be possible for you or someone else (@Eldemarkki) to implement the funcitonality to the Frontend side so that we can enable it immediately after merging? |
|
Should we also automatically hide new heartbeats for projects where there exists a hidden project with the same name and from the same user, regardless of what the client says? Or should we just leave the responsibility to the client? |
lajp
approved these changes
May 27, 2024
lajp
requested changes
May 27, 2024
lajp
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very epic Rust code. Probably not very good looking and I will be sticking with TS from now.
Adds support for hiding activities for specific projects. This has been implemented client-side with hashes on the VSCode extension but I'd personally prefer to myself see the projects with names. Currently hidden projects can't be distinguished from each other and they will all have a empty string as the project name along with
"hidden": true.