Various fixes for tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the expected mode before 'acq' became the default. Fixes an issue with the init test.
This ends up hanging on the auto-reconnection otherwise. This was a bit unexpected, as test_mode should break us out before another communication.
This makes it look like initialize happened twice, since the message included in the return is also logged in the same place.
This was commented because it was causing issues, but we should just drop it altogether. It's better that 'init' doesn't loop forever until a connection is made. Rather it should fail and report as failed.
This was missing, but needed since it's checked in init(). This is maybe a bit of a hack, but by setting to 0 we skip setting 'acq_params' and end running with the default three channel query given by the the default 'channels' on 'monitor_output()'. This is the old behavior before the addition of 'ScpiPsuInterface'.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See simonsobs#715 (review).