Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the HTML export template #3043

Merged
merged 5 commits into from
Jul 29, 2023
Merged

Conversation

davep
Copy link
Contributor

@davep davep commented Jul 20, 2023

This PR fixes the HTML export template, addressing the issue raised in #3021

In doing so there's also an update to the pre-commit configuration (without it I wasn't able to commit the change -- the update is stolen from the same config file in Textual).

@davep davep added the bug Something isn't working label Jul 20, 2023
@davep davep self-assigned this Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (31c1fb6) 98.31% compared to head (7297ac9) 98.31%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3043   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          74       74           
  Lines        8016     8016           
=======================================
  Hits         7881     7881           
  Misses        135      135           
Flag Coverage Δ
unittests 98.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/_export_format.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willmcgugan willmcgugan merged commit 0c8bb03 into Textualize:master Jul 29, 2023
17 checks passed
@davep davep deleted the fix-export-html branch August 17, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants