Fixed Text.wrap trimming lines in no_wrap mode #3843
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `rstrip_end` and `truncate` were being called even when soft wrapping was enabled, which led to visual bugs where trailing spaces and their backgrounds were incorrectly trimmed. This change ensures that line trimming logic is now correctly applied only during hard wrapping. This also updates the expected output in a `Syntax` test that was dependent on the old buggy behavior. Fixes Textualize#3841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Previously,
rstrip_endandtruncatewere being called even when soft wrapping was enabled, which led to visual bugs where trailing spaces and their backgrounds were incorrectly trimmed.This change ensures that line trimming logic is now correctly applied only during hard wrapping.
This also updates the expected output in a
Syntaxtest that was dependent on the old buggy behavior.Fixes #3841