Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds aria-labels to svg social icon links #1092

Merged
merged 4 commits into from
Nov 25, 2021
Merged

Adds aria-labels to svg social icon links #1092

merged 4 commits into from
Nov 25, 2021

Conversation

jeanadev
Copy link
Contributor

Fixes for #1088

This code could probably be refactored to include less repeating (DRY).

But now svg icon links meet the WCAG 2.4.4 https://www.w3.org/TR/2008/REC-WCAG20-20081211/#navigation-mechanisms-refs. Also see: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA8.html

Thanks to Adam Tegan for helping me out with understanding the svelt to get this far.

@vercel
Copy link

vercel bot commented Nov 19, 2021

@tsidel is attempting to deploy a commit to the That Conference Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/that-conference/that.us/HeVo3gjBjrzZuFNBLKK4HEYPWsWr
✅ Preview: https://thatus-git-fork-tsidel-master-that-conference.vercel.app

@theClarkSell theClarkSell added accessibility ui/ux items related to the overall UX and UI labels Nov 25, 2021
@theClarkSell theClarkSell merged commit 2bf25d2 into ThatConference:master Nov 25, 2021
@theClarkSell
Copy link
Member

@all-contributors add @tsidel for code

@allcontributors
Copy link
Contributor

@csell5

I've put up a pull request to add @tsidel! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility ui/ux items related to the overall UX and UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants