-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major code changes #4
base: feat/movement-api
Are you sure you want to change the base?
Major code changes #4
Conversation
I've moved this into a separate branch for the time being since I've already got pending changes in other branches that may need to be tailored to these large changes too, once I believe both are ready I'll merge them into the main branch. |
protected void playEntityOnFireExtinguishedSound() {} | ||
|
||
/** | ||
* These methods prevent pets from being saved in the worlds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lul
|
||
@Override | ||
public boolean isOnPortalCooldown() { | ||
return true; // Prevents mob from teleporting from a portal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can always change this in the future, I do want to emulate a player as much as possible with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, just want to ask about naming conventions in one place and I should be fine merging this.
} | ||
|
||
|
||
private Path fixThisStupidThing() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting naming, may I ask what this and alsoFixThis do?
return true; | ||
} | ||
|
||
if (args[0].equalsIgnoreCase("command")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command management regarding this shall be changed in a separate branch, so don't worry about doing too much with it
Adds:
Changes: