-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item event framework (plus other changes now) #854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Item event framework! Related things: Rewrote existing item activate scripts to use it (else they would fire during equip etc too) Polymorph merge should work. At the moment nothing live actually makes use of this. This commit contains `is_physadapt` as a simpleish demo of it, to use, set the tag of an item to "physadapt" and unequip/requip it. Other things that are in this commit: Fix towards identify webhook firing twice from stores Fix compile warning from 70_mod_polymorph attempting to use and define a variable in the same statement Minor treasure map dig code refactor, this also makes digging make maps disappear when you complete the map you have open (previously only undiggables would do this) Fix for ILR text in item descriptions not updating Fix for on hit cast properties on weapons getting merged onto creature hides during polymorph Fix batch file stop scripts Fix dev folder compile for new scripts Fix one-off compile complaint messages
- Isle of the Maker golem changes: Iron Golems were disproprotionately nasty compared to the other types. - Iron Golem: 17 HD -> 15 HD, 32 Str -> 28 Str, 30 AC -> 28 AC - Stone Golem: remains 14 HD, 25 Str- > 26 Str, 23 AC -> 26 AC - Clay Golem: 11 HD -> 13 HD, remains 24 Str, 21 AC -> 24 AC - Animated Artifact: 21 AC -> 23 AC, 13 Str -> 16 Str - Second level: Slightly increased the number of smaller golems in the early encounters, especially on Ferron's side. The numbers of golems in the boss fights are unchanged.
Finally got round to sorting the conflicts on this - it is probably good to go, just pending possible server hardware migration. |
Scratch that, this needs a treasure seed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related changes:
Modified existing item activate scripts to use it (else the framework would fire them during equip etc too)
Polymorph merge should work.
At the moment nothing live actually makes use of this. This commit contains
is_physadapt
as a simpleish demo of it, to use, set the tag of an item to "physadapt" and unequip/requip it.Other things that are in this commit:
Fix towards identify webhook firing twice from stores
Fix compile warning from 70_mod_polymorph attempting to use a variable in its own initialisation statement
Minor treasure map dig code refactor. Also made the map UI close itself when completed (previously only finding treasure in undiggable locations would do this)
Fix for ILR text in item descriptions not updating when the item's actual ILR changed
Fix on hit cast properties on weapons getting merged onto creature hides during polymorph
Fix batch file stop scripts (swapped yaml names, and wrong directory)
Fix dev folder compile for new scripts
Fix one-off compile complaint messages
Add two new item properties that don't show ingame that can be used to manipulate item prices (and ILR).
Added an Isle of the Maker creature palette category as there are several constructs with the same names and life was getting confusing.
Actual content changes in this PR: