Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some loot refactoring #865

Merged
merged 5 commits into from
Dec 8, 2024
Merged

Conversation

Logg-y
Copy link
Collaborator

@Logg-y Logg-y commented Dec 7, 2024

Internal changes:

  • Loot selection (Generate/SelectTierItem) are gone, all this stuff is moved to inc_lootselect. This offers functions that can do more things than before, and hopefully offers functions with less confusing names that were there before. The internal mechanics are unfortunately more complicated due to accepting custom weightings for everything but most usage should be able to go through one of the exposed helpers instead.
  • Loot assignment in parties moved to inc_lootowing
  • Updated all the scripts that used the old functions to use the new equivalents
  • Minor, but moved boss/semiboss adjustment to creature XP values inside the XP function, because all users of it were doing exactly the same logic externally on the return value anyway...
  • Exposed a couple of operations of the personal loot system that might be useful elsewhere.

party_credit is still quite a long thing. It could be split up, but I'm not sure about that.

Actual functionality changes:

  • Implemented "first boss kill drops an equippable item of tier based on ACR", aka that feature that made me want to clean this stuff up because making it under the old system would have just added to the pile of confusing functions.
  • Expected loot value from containers turned out to be very slightly (think like 1%) different according to the newly rewritten debug stuff and the old. I'm not entirely sure why.

I have spent an hour or two running around locally (and fixed some silly mistakes), but in its current state it seemed okay.

@Logg-y Logg-y merged commit 4f9c792 into The-Frozen-North:master Dec 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant