Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autotuner] Remote functionality check #2334

Merged
merged 10 commits into from
Oct 12, 2024
Merged

[Autotuner] Remote functionality check #2334

merged 10 commits into from
Oct 12, 2024

Conversation

luarss
Copy link
Contributor

@luarss luarss commented Sep 10, 2024 •
edited
Loading

Implemented using docker compose - 1 for ray head, 1 for ray worker. Both using the ORFS-flow-dev image built during CI, so no additional overhead needed other than Autotuner reqs installed.

Tasks

  • Use the --address and --port cli args in distributed.py
  • Dependency installer for ci-install - docker compose

@luarss luarss marked this pull request as draft September 11, 2024 01:15
luarss
luarss commented Sep 11, 2024
View reviewed changes
tools/AutoTuner/setup.sh Outdated Show resolved Hide resolved
luarss
luarss commented Sep 11, 2024
View reviewed changes
flow/test/test_helper.sh Outdated Show resolved Hide resolved
@luarss luarss changed the title [Autotuner] WIP: Remote functionality check [Autotuner] Remote functionality check Sep 14, 2024
@luarss luarss marked this pull request as ready for review September 14, 2024 10:21
@luarss luarss self-assigned this Oct 8, 2024
@luarss luarss added the autotuner Flow autotuner label Oct 8, 2024
vvbandeira
vvbandeira reviewed Oct 10, 2024
View reviewed changes
flow/test/test_helper.sh Outdated Show resolved Hide resolved
flow/test/test_helper.sh Outdated Show resolved Hide resolved
tools/AutoTuner/docker-compose.yml Outdated Show resolved Hide resolved
tools/AutoTuner/docker-compose.yml Outdated Show resolved Hide resolved
vvbandeira
vvbandeira reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@vvbandeira vvbandeira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict.

tools/AutoTuner/docker-compose.yml Outdated Show resolved Hide resolved
@vvbandeira vvbandeira enabled auto-merge (squash) October 12, 2024 05:05
@vvbandeira vvbandeira merged commit ec8a1b0 into The-OpenROAD-Project:master Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvbandeira vvbandeira vvbandeira approved these changes

Assignees

@luarss luarss

Labels
autotuner Flow autotuner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luarss @vvbandeira