Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odb genpy refactor #6742

Merged
merged 24 commits into from
Feb 20, 2025
Merged

Odb genpy refactor #6742

merged 24 commits into from
Feb 20, 2025

Conversation

openroad-ci
Copy link
Collaborator

No description provided.

@maliberty
odb: refactor out helper functions in relationship generation
006befe 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: generator change get_class_index -> get_class
96ed4f3 
No need to convert to index and back again

Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py whitespace format
550f729 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py fix message
6a41f3a 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py rm unused var
5c604d6 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: change first/second to parent/child in code gen relationship
b9e84fc 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py simplify var names
c1d9920 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: put generation code in function scope
ef4dbdb 
Avoid accidental non-local references through global variables

Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py rename toBeMerged -> to_be_merged
2b31901 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py place startup code together
337c3ae 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: put main code in function scope
ad59b57 
Avoid accidental non-local references through global variables

Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py inline single use variables in main
c3774df 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py refactor out function process_field
da6373b 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py rename process_field -> add_field_attributes
236882a 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py refactor out function add_bitfield
77756b5 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py move flags field creation to add_bitfield_flags
68d05fd 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py refactor out function generate_relations
3a8fe13 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py rename struct to flags_struct
f28e8b6 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: gen.py add function comments
8e58cd6 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: generator add more function comments
4db863c 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: move template sort code to custom Jinja filter 'by_base_type'
a04e5a3 
Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: use a template macro for DRY struct & enum generation
cf90fb1 
Shared between public and private structs/enums.

Signed-off-by: Matt Liberty <[email protected]>
@maliberty
odb: move default dbObject base class to python in code gen
087b07a 
Signed-off-by: Matt Liberty <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty enabled auto-merge February 20, 2025 07:28
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty merged commit 5dbafad into The-OpenROAD-Project:master Feb 20, 2025
11 checks passed
@maliberty maliberty deleted the odb-genpy-refactor branch February 20, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees

@maliberty maliberty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openroad-ci @maliberty