Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order of query string parameters in the TimedDealProvider #290

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ArdenHide
Copy link
Member

No description provided.

@ArdenHide ArdenHide self-assigned this Mar 6, 2025
@ArdenHide ArdenHide linked an issue Mar 6, 2025 that may be closed by this pull request
@ArdenHide ArdenHide marked this pull request as ready for review March 6, 2025 15:09
Copy link

github-actions bot commented Mar 6, 2025

Diagrams

Diagrams summary
URL PATH
include URL ./diagrams/include.puml
Environments URL ./diagrams/src/MetaDataAPI/Environments.puml
LambdaFunction URL ./diagrams/src/MetaDataAPI/LambdaFunction.puml
DefaultServiceProvider URL ./diagrams/src/MetaDataAPI/DefaultServiceProvider.puml
PoolIdNotInSupplyRangeResponse URL ./diagrams/src/MetaDataAPI/Response/PoolIdNotInSupplyRangeResponse.puml
GeneralErrorResponse URL ./diagrams/src/MetaDataAPI/Response/GeneralErrorResponse.puml
ChainNotSupportedResponse URL ./diagrams/src/MetaDataAPI/Response/ChainNotSupportedResponse.puml
SuccessResponse URL ./diagrams/src/MetaDataAPI/Response/SuccessResponse.puml
ValidationErrorResponse URL ./diagrams/src/MetaDataAPI/Response/ValidationErrorResponse.puml
LambdaResponse URL ./diagrams/src/MetaDataAPI/Response/LambdaResponse.puml
CollateralProvider URL ./diagrams/src/MetaDataAPI/Providers/CollateralProvider.puml
AbstractProvider URL ./diagrams/src/MetaDataAPI/Providers/AbstractProvider.puml
DelayVaultProvider URL ./diagrams/src/MetaDataAPI/Providers/DelayVaultProvider.puml
TimedDealProvider URL ./diagrams/src/MetaDataAPI/Providers/TimedDealProvider.puml
DealProvider URL ./diagrams/src/MetaDataAPI/Providers/DealProvider.puml
RefundProvider URL ./diagrams/src/MetaDataAPI/Providers/RefundProvider.puml
LockDealProvider URL ./diagrams/src/MetaDataAPI/Providers/LockDealProvider.puml
Erc721Metadata URL ./diagrams/src/MetaDataAPI/Providers/Attributes/Erc721Metadata.puml
Erc721MetadataItemAttribute URL ./diagrams/src/MetaDataAPI/Providers/Attributes/Erc721MetadataItemAttribute.puml
DisplayType URL ./diagrams/src/MetaDataAPI/Providers/Attributes/DisplayType.puml
Erc721MetadataItem URL ./diagrams/src/MetaDataAPI/Providers/Attributes/Erc721MetadataItem.puml
QueryStringToken URL ./diagrams/src/MetaDataAPI/Providers/Image/QueryStringToken.puml
UrlifyProvider URL ./diagrams/src/MetaDataAPI/Providers/Image/UrlifyProvider.puml
Erc20Token URL ./diagrams/src/MetaDataAPI/Services/Erc20/Erc20Token.puml
IErc20Provider URL ./diagrams/src/MetaDataAPI/Services/Erc20/IErc20Provider.puml
Erc20Provider URL ./diagrams/src/MetaDataAPI/Services/Erc20/Erc20Provider.puml
ImageService URL ./diagrams/src/MetaDataAPI/Services/Image/ImageService.puml
IChainManager URL ./diagrams/src/MetaDataAPI/Services/ChainsInfo/IChainManager.puml
ChainInfo URL ./diagrams/src/MetaDataAPI/Services/ChainsInfo/ChainInfo.puml
DbChainManager URL ./diagrams/src/MetaDataAPI/Services/ChainsInfo/DbChainManager.puml
LambdaRequest URL ./diagrams/src/MetaDataAPI/Request/LambdaRequest.puml
LockDealNftServiceExtensions URL ./diagrams/src/MetaDataAPI/Extensions/LockDealNftServiceExtensions.puml
DateTimeExtensions URL ./diagrams/src/MetaDataAPI/Extensions/DateTimeExtensions.puml
LambdaRequestValidator URL ./diagrams/src/MetaDataAPI/Validation/LambdaRequestValidator.puml

Copy link

github-actions bot commented Mar 6, 2025

Summary

Summary
Generated on: 03/06/2025 - 15:10:06
Coverage date: 03/06/2025 - 15:10:05
Parser: Cobertura
Assemblies: 1
Classes: 29
Files: 29
Line coverage: 23.8% (97 of 406)
Covered lines: 97
Uncovered lines: 309
Coverable lines: 406
Total lines: 888
Branch coverage: 15.7% (6 of 38)
Covered branches: 6
Total branches: 38
Method coverage: Feature is only available for sponsors

Coverage

MetaDataAPI - 23.8%
Name Line Branch
MetaDataAPI 23.8% 15.7%
MetaDataAPI.DefaultServiceProvider 0%
MetaDataAPI.Extensions.DateTimeExtensions 100%
MetaDataAPI.Extensions.LockDealNftServiceExtensions 100%
MetaDataAPI.LambdaFunction 0% 0%
MetaDataAPI.Providers.AbstractProvider 0% 0%
MetaDataAPI.Providers.Attributes.Erc721Metadata 0%
MetaDataAPI.Providers.Attributes.Erc721MetadataItem 0%
MetaDataAPI.Providers.Attributes.Erc721MetadataItemAttribute 0%
MetaDataAPI.Providers.CollateralProvider 0%
MetaDataAPI.Providers.DealProvider 0%
MetaDataAPI.Providers.DelayVaultProvider 0%
MetaDataAPI.Providers.Image.QueryStringToken 0%
MetaDataAPI.Providers.Image.UrlifyProvider 0% 0%
MetaDataAPI.Providers.LockDealProvider 0%
MetaDataAPI.Providers.RefundProvider 0%
MetaDataAPI.Providers.TimedDealProvider 0%
MetaDataAPI.Request.LambdaRequest 100% 100%
MetaDataAPI.Response.ChainNotSupportedResponse 0%
MetaDataAPI.Response.GeneralErrorResponse 0%
MetaDataAPI.Response.LambdaResponse 0% 0%
MetaDataAPI.Response.PoolIdNotInSupplyRangeResponse 0%
MetaDataAPI.Response.SuccessResponse 0%
MetaDataAPI.Response.ValidationErrorResponse 0% 0%
MetaDataAPI.Services.ChainsInfo.ChainInfo 100%
MetaDataAPI.Services.ChainsInfo.DbChainManager 0%
MetaDataAPI.Services.Erc20.Erc20Provider 100%
MetaDataAPI.Services.Erc20.Erc20Token 100%
MetaDataAPI.Services.Image.ImageService 0% 0%
MetaDataAPI.Validation.LambdaRequestValidator 100%

@ArdenHide ArdenHide merged commit e1ed8b4 into master Mar 6, 2025
3 checks passed
@ArdenHide ArdenHide deleted the issue_#289 branch March 6, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update order of query string parameters in the TimedDealProvider
2 participants